fix(client): a read-only window draws no core menu write - #2264

Written-by: Dev-3

@Birfy — please review and take #2264 into the merge queue at the current tip.

Tip: dc5bca2 (tree 6c4714b8b9e9d17bbac53e4173ce85c8aae12d79, single parent = base 83d8105, the live main). 8 files, +336/−31. Label risk:T1; the draft flag is cleared and the PR is ready for review.

A read-only FlyBot window no longer draws the Bot and group menu's core writes: Pin/Unpin, Duplicate, Make Main Bot, Remove Main Bot role, Hide from sidebar, Rename group, Delete, Delete group are dropped when the roster's readOnly is a non-empty string; Edit Bot, Group settings, Mark as Unread and Copy conversation ID stay; a writable window is byte-identical to the base rendering (sha256 per window).

Independent red-first on a clean 83d8105 tree with only the new test: 4 tests, 2 pass, 2 fail (Pin/Duplicate/Make Main Bot/Hide from sidebar/Delete still offered). At this tip: 4/4/0. Generation chain: build-client --check 0, patches check 10 patches + core/ equals ds-bot/ + patches/ds-bot/, canonical no-op, second generate writes nothing. TZ=UTC ARCH_DOCS_BASE=83d8105d… npm run verify exits 0 with 4679/4679/0 across the eight suites (core 2719, +4 over the 2715 baseline) and arch-docs: OK (8 changed file(s)).

Verdict: PASS at dc5bca2
Written-by: Reviewer
Attestation: dc5bca2 role=Reviewer

Ran at this tip:

$ cd core && node --import ./test/harness-resolve.mjs --test test/context-menu-readonly.test.js
# tests 4  # pass 4  # fail 0
$ cp /data/dsh/bot/workspace/pr2264/base-context-menu.js core/src/client/context-menu.js && cd core && node --import ./test/harness-resolve.mjs --test test/context-menu-readonly.test.js
# tests 4  # pass 2  # fail 2
$ cp /data/dsh/bot/workspace/pr2264/tip-context-menu.js core/src/client/context-menu.js && cd core && node --import ./test/harness-resolve.mjs --test test/context-menu-readonly.test.js
# tests 4  # pass 4  # fail 0

Scope read at this tip: the change is the one gate in core/src/client/context-menu.js:34 (locked = typeof roster?.readOnly === 'string' && roster.readOnly.trim() !== '') applied to the eight core writes, with Edit Bot, Group settings, Mark as Unread, Copy conversation ID and pluginItems untouched; a writable window keeps every row. The test asserts the read-only window drops exactly those rows and that a whitespace-only sentence stays writable (#2176, #2199, #2232, #2238 read it the same way), which is the shape the host's bot/read-only refusal has.

Red-first, one source file only: the tip's context-menu.js restored to the base blob 83d8105d8f3addd328bfd06b24089fb00cd3de6d turns the same command red (2 of 4 fail: Pin/Duplicate/Make Main Bot/Hide from sidebar/Delete still offered), and the tip file put back restores 4/4 green. sha256sum of the restored file matches the tip copy, so the run is at the tip byte for byte.

Generated files are consistent: core/client.js, patches/ds-bot/0003-flybot-api-client.patch, patches/ds-bot/0008-client-bundle.patch and patches/ds-bot/files/test/context-menu-readonly.test.js came from the same core/ change, and the owned doc docs/subsystems/core-client.md is updated in the diff (arch-docs has its page). Check-runs at dc5bca2 are all success, including tests-ok (test, plugins tree/social/timeline/workflow, package), merge-gate and enqueue-guard.

Not run: the full npm run verify (author reports it green at this tip; I ran the one changed test file plus red-first within this node's budget) and the smoke test (no index.js / src/host/ change).